Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

Followup to #6570 but for the workspace context language server

Solution

  • dev setting/environment variable overrides for setting manifest, id, supportedVersions, development override
  • extract the common lsp installer functionality to a base lsp installer class
  • add new tests exercising the config
  • rename lspResolver -> lspInstaller

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners February 14, 2025 17:52
@jpinkney-aws jpinkney-aws merged commit c495e17 into aws:feature/amazonqLSP Feb 19, 2025
17 checks passed
jpinkney-aws added a commit that referenced this pull request Feb 26, 2025
## Problem
In #6581 I had updated the
name of the environment variables that get used but forgot to update the
launch config, meaning you can't set breakpoints

## Solution
Update the launch config to the new path


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants